[WebProfilerBundle] Handle 'unsafe-eval' in CSP #27525
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In base_js_html.twig eval is used but the ContentSecurityPolicyHandler never adds 'unsafe-eval' to the nonce which breaks the profiler with very strict CSPs
I was using the profiler bundle with the very strict CSP "default-src 'self'; script-src 'self';" and the browser was not loading the toolbar because of CSP violations.
This change uses already existing functionality and loops through source values ("unsafe-inline" and "unsafe-eval") where before just "unsafe-inline" was used. I also adapted the unit tests for it, added new tests for edge cases and my case that failed. I honestly don't know if this is the best way to fix them / handle unsafe-eval, but this seems to be working fine for me.