symfony · kralos · May 23, 2018 · May 23, 2018 · May 23, 2018 · May 23, 2018
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -19,6 +19,7 @@
        <env name="LDAP_PORT" value="3389" />
        <env name="REDIS_HOST" value="localhost" />
        <env name="MEMCACHED_HOST" value="localhost" />
+        <env name="MONGODB_HOST" value="localhost" />
    </php>

    <testsuites>

diff --git a/src/Symfony/Component/Lock/Store/MongoDbStore.php b/src/Symfony/Component/Lock/Store/MongoDbStore.php
@@ -0,0 +1,288 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Lock\Store;
+
+use Symfony\Component\Lock\Exception\InvalidArgumentException;
+use Symfony\Component\Lock\Exception\LockConflictedException;
+use Symfony\Component\Lock\Exception\LockExpiredException;
+use Symfony\Component\Lock\Exception\LockStorageException;
+use Symfony\Component\Lock\Exception\NotSupportedException;
+use Symfony\Component\Lock\Key;
+use Symfony\Component\Lock\StoreInterface;
+
+/**
+ * MongoDbStore is a StoreInterface implementation using MongoDB as a storage
+ * engine.
+ *
+ * @author Joe Bennett <joe@assimtech.com>
+ */
+class MongoDbStore implements StoreInterface
+{
+    private $mongo;
+    private $options;
+    private $initialTtl;
+
+    private $collection;
+
+    /**
+     * @param \MongoDB\Client $mongo
+     * @param array           $options    See below
+     * @param float           $initialTtl The expiration delay of locks in seconds
+     *
+     * Options:
+     *      database:    The name of the database [required]
+     *      collection:  The name of the collection [default: lock]
+     *
+     * CAUTION: The locked resouce name is indexed in the _id field of the
+     * lock collection.
+     * An indexed field's value in MongoDB can be a maximum of 1024 bytes in
+     * length inclusive of structural overhead.
+     *
+     * @see https://docs.mongodb.com/manual/reference/limits/#Index-Key-Limit
+     *
+     * CAUTION: This store relies on all client and server nodes to have
+     * synchronized clocks for lock expiry to occur at the correct time.
+     * To ensure locks don't expire prematurely; the lock TTL should be set
+     * with enough extra time to account for any clock drift between nodes.
+     * @see self::createTTLIndex()
+     *
+     * writeConcern, readConcern and readPreference are not specified by
+     * MongoDbStore meaning the collection's settings will take effect.
+     * @see https://docs.mongodb.com/manual/applications/replication/
+     */
+    public function __construct(\MongoDB\Client $mongo, array $options, float $initialTtl = 300.0)
+    {
+        if (!isset($options['database'])) {
+            throw new InvalidArgumentException(
+                'You must provide the "database" option for MongoDBStore'
+            );
+        }
+
+        $this->mongo = $mongo;
+
+        $this->options = array_merge(array(
+            'collection' => 'lock',
+        ), $options);
+
+        $this->initialTtl = $initialTtl;
+    }
+
+    /**
+     * Create a TTL index to automatically remove expired locks.
+     *
+     * This should be called once during database setup.
+     *
+     * Alternatively the TTL index can be created manually:
+     *
+     *  db.lock.ensureIndex(
+     *      { "expires_at": 1 },
+     *      { "expireAfterSeconds": 0 }
+     *  )
+     *
+     * A TTL index MUST BE used on MongoDB 2.2+ to automatically clean up expired locks.
+     *
+     * @see http://docs.mongodb.org/manual/tutorial/expire-data/
+     *
+     * @return string The name of the created index as a string
+     *
+     * @throws \MongoDB\Exception\UnsupportedException     if options are not supported by the selected server
+     * @throws \MongoDB\Exception\InvalidArgumentException for parameter/option parsing errors
+     * @throws \MongoDB\Exception\DriverRuntimeException   for other driver errors (e.g. connection errors)
+     */
+    public function createTTLIndex(): string
+    {
+        $keys = array(
+            'expires_at' => 1,
+        );
+
+        $options = array(
+            'expireAfterSeconds' => 0,
+        );
+
+        return $this->getCollection()->createIndex($keys, $options);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function save(Key $key)
+    {
+        $token = $this->getToken($key);
+        $now = microtime(true);
+
+        $filter = array(
+            '_id' => (string) $key,
+            '$or' => array(
+                array(
+                    'token' => $token,
+                ),
+                array(
+                    'expires_at' => array(
+                        '$lte' => $this->createDateTime($now),
+                    ),
+                ),
+            ),
+        );
+
+        $update = array(
+            '$set' => array(
+                '_id' => (string) $key,
+                'token' => $token,
+                'expires_at' => $this->createDateTime($now + $this->initialTtl),
+            ),
+        );
+
+        $options = array(
+            'upsert' => true,
+        );
+
+        $key->reduceLifetime($this->initialTtl);
+
+        try {
+            $this->getCollection()->updateOne($filter, $update, $options);
+        } catch (\MongoDB\Driver\Exception\WriteException $e) {
+            throw new LockConflictedException('Failed to acquire lock', 0, $e);
+        } catch (\Exception $e) {
+            throw new LockStorageException($e->getMessage(), 0, $e);
+        }
+
+        if ($key->isExpired()) {
+            throw new LockExpiredException(sprintf('Failed to store the "%s" lock.', $key));
+        }
+    }
+
+    public function waitAndSave(Key $key)
+    {
+        throw new NotSupportedException(sprintf(
+            'The store "%s" does not supports blocking locks.',
+            __CLASS__
+        ));
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function putOffExpiration(Key $key, $ttl)
+    {
+        $now = microtime(true);
+
+        $filter = array(
+            '_id' => (string) $key,
+            'token' => $this->getToken($key),
+            'expires_at' => array(
+                '$gte' => $this->createDateTime($now),
+            ),
+        );
+
+        $update = array(
+            '$set' => array(
+                '_id' => (string) $key,
+                'expires_at' => $this->createDateTime($now + $ttl),
+            ),
+        );
+
+        $options = array(
+            'upsert' => true,
+        );
+
+        $key->reduceLifetime($ttl);
+
+        try {
+            $this->getCollection()->updateOne($filter, $update, $options);
+        } catch (\MongoDB\Driver\Exception\WriteException $e) {
+            throw new LockConflictedException('Failed to put off the expiration of the lock', 0, $e);
+        } catch (\Exception $e) {
+            throw new LockStorageException($e->getMessage(), 0, $e);
+        }
+
+        if ($key->isExpired()) {
+            throw new LockExpiredException(sprintf(
+                'Failed to put off the expiration of the "%s" lock within the specified time.',
+                $key
+            ));
+        }
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function delete(Key $key)
+    {
+        $filter = array(
+            '_id' => (string) $key,
+            'token' => $this->getToken($key),
+        );
+
+        $options = array();
+
+        $this->getCollection()->deleteOne($filter, $options);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function exists(Key $key)
+    {
+        $filter = array(
+            '_id' => (string) $key,
+            'token' => $this->getToken($key),
+            'expires_at' => array(
+                '$gte' => $this->createDateTime(),
+            ),
+        );
+
+        $doc = $this->getCollection()->findOne($filter);
+
+        return null !== $doc;
+    }
+
+    private function getCollection(): \MongoDB\Collection
+    {
+        if (null === $this->collection) {
+            $this->collection = $this->mongo->selectCollection(
+                $this->options['database'],
+                $this->options['collection']
+            );
+        }
+
+        return $this->collection;
+    }
+
+    /**
+     * @param float $seconds Seconds since 1970-01-01T00:00:00.000Z supporting millisecond precision. Defaults to now.
+     *
+     * @return \MongoDB\BSON\UTCDateTime
+     */
+    private function createDateTime(float $seconds = null): \MongoDB\BSON\UTCDateTime
+    {
+        if (null === $seconds) {
+            $seconds = microtime(true);
+        }
+
+        $milliseconds = $seconds * 1000;
+
+        return new \MongoDB\BSON\UTCDateTime($milliseconds);
+    }
+
+    /**
+     * Retrieves an unique token for the given key.
+     */
+    private function getToken(Key $key): string
+    {
+        if (!$key->hasState(__CLASS__)) {
+            $token = base64_encode(random_bytes(32));
+            $key->setState(__CLASS__, $token);
+        }
+
+        return $key->getState(__CLASS__);
+    }
+}
diff --git a/src/Symfony/Component/Lock/StoreInterface.php b/src/Symfony/Component/Lock/StoreInterface.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Lock;

 use Symfony\Component\Lock\Exception\LockConflictedException;
+use Symfony\Component\Lock\Exception\LockExpiredException;
 use Symfony\Component\Lock\Exception\NotSupportedException;

 /**
@@ -25,6 +26,7 @@ interface StoreInterface
     * Stores the resource if it's not locked by someone else.
     *
     * @throws LockConflictedException
+     * @throws LockExpiredException
     */
    public function save(Key $key);

@@ -34,6 +36,7 @@ public function save(Key $key);
     * If the store does not support this feature it should throw a NotSupportedException.
     *
     * @throws LockConflictedException
+     * @throws LockExpiredException
     * @throws NotSupportedException
     */
    public function waitAndSave(Key $key);
@@ -46,6 +49,7 @@ public function waitAndSave(Key $key);
     * @param float $ttl amount of second to keep the lock in the store
     *
     * @throws LockConflictedException
+     * @throws LockExpiredException
     * @throws NotSupportedException
     */
    public function putOffExpiration(Key $key, $ttl);

diff --git a/src/Symfony/Component/Lock/Tests/Store/MongoDbClientTest.php b/src/Symfony/Component/Lock/Tests/Store/MongoDbClientTest.php
@@ -0,0 +1,65 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Lock\Tests\Store;
+
+use Symfony\Component\Lock\Store\MongoDbStore;
+
+/**
+ * @author Joe Bennett <joe@assimtech.com>
+ */
+class MongoDbClientTest extends AbstractStoreTest
+{
+    use ExpiringStoreTestTrait;
+
+    public static function setupBeforeClass()
+    {
+        try {
+            if (!class_exists(\MongoDB\Client::class)) {
+                throw new \RuntimeException('The mongodb/mongodb package is required.');
+            }
+            $client = self::getMongoConnection();
+            $client->listDatabases();
+        } catch (\Exception $e) {
+            self::markTestSkipped($e->getMessage());
+        }
+    }
+
+    protected static function getMongoConnection(): \MongoDB\Client
+    {
+        return new \MongoDB\Client('mongodb://'.getenv('MONGODB_HOST'));
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function getClockDelay()
+    {
+        return 250000;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getStore()
+    {
+        return new MongoDbStore(self::getMongoConnection(), array(
+            'database' => 'test',
+        ));
+    }
+
+    public function testCreateIndex()
+    {
+        $store = $this->getStore();
+
+        $this->assertEquals($store->createTTLIndex(), 'expires_at_1');
+    }
+}