Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Messenger] Fix new AMQP Transport test with Envelope & fix contract #27220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2018
Merged

[Messenger] Fix new AMQP Transport test with Envelope & fix contract #27220

merged 1 commit into from
May 10, 2018

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented May 10, 2018 •
edited
Loading

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets https://travis-ci.org/symfony/symfony/jobs/377246434#L3685-L3686, https://ci.appveyor.com/project/fabpot/symfony/build/1.0.36261#L297
License MIT
Doc PR N/A

@ogizanagi ogizanagi requested a review from sroze May 10, 2018 12:44
@ogizanagi ogizanagi added this to the 4.1 milestone May 10, 2018
sroze
sroze approved these changes May 10, 2018
View reviewed changes
Copy link
Contributor

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to send that one hehe. Thanks!

@yceruto
Copy link
Member

yceruto commented May 10, 2018 •
edited
Loading

Me too :) Could we have a test case this? or it's already covered?

@ogizanagi
Copy link
Contributor Author

@yceruto : It's already covered (see failing tests in the description :) ).
We missed it because of the component activity and not systematically rebasing PRs after a merge, hence not re-triggering a fresh build.

@sroze
Copy link
Contributor

sroze commented May 10, 2018

Thank you @ogizanagi.

@sroze sroze merged commit 7223bd7 into symfony:4.1 May 10, 2018
sroze added a commit that referenced this pull request May 10, 2018
@sroze
bug #27220 [Messenger] Fix new AMQP Transport test with Envelope & fi…
3cc4a70 
…x contract (ogizanagi)

This PR was merged into the 4.1 branch.

Discussion
----------

[Messenger] Fix new AMQP Transport test with Envelope & fix contract

| Q             | A
| ------------- | ---
| Branch?       | 4.1 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/377246434#L3685-L3686, https://ci.appveyor.com/project/fabpot/symfony/build/1.0.36261#L297   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

7223bd7 [Messenger] Fix new AMQP Transport test with Envelope
@ogizanagi ogizanagi deleted the fix/new_amqp_test_envelope branch May 10, 2018 15:08
@fabpot fabpot mentioned this pull request May 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroze sroze sroze approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ogizanagi @yceruto @sroze @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.