Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Debug] Fixed the formatPath when a custom fileLinkFormat is defined #27098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Debug] Fixed the formatPath when a custom fileLinkFormat is defined #27098

wants to merge 1 commit into from

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Apr 30, 2018 •
edited
Loading

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27097
License MIT
Doc PR

@lyrixx lyrixx force-pushed the debug-parse-error-link branch from 6a3e9d1 to 47bdc7a Compare April 30, 2018 10:28
@lyrixx lyrixx changed the base branch from 2.7 to 2.8 April 30, 2018 10:28
@lyrixx lyrixx force-pushed the debug-parse-error-link branch from 47bdc7a to 6983b28 Compare April 30, 2018 10:34
@lyrixx lyrixx changed the base branch from 2.8 to 2.7 April 30, 2018 10:34
@lyrixx lyrixx changed the title [Debug] Fixed the formatPath when a custom fileLinkFormat is defined WIP - [Debug] Fixed the formatPath when a custom fileLinkFormat is defined Apr 30, 2018
@lyrixx lyrixx force-pushed the debug-parse-error-link branch from 6983b28 to ec94593 Compare April 30, 2018 10:47
@lyrixx lyrixx changed the title WIP - [Debug] Fixed the formatPath when a custom fileLinkFormat is defined [Debug] Fixed the formatPath when a custom fileLinkFormat is defined Apr 30, 2018
@nicolas-grekas
Copy link
Member

There is #27074 pending on the topic, but I'm not sure it fixes your issue actually, can you try it?
I don't think the special format has been introduced in 2.7, could you please check?
Maybe my PR should somehow call setFileLinkFormat()?

@lyrixx lyrixx force-pushed the debug-parse-error-link branch from ec94593 to 2c7fe42 Compare April 30, 2018 12:39
@lyrixx
Copy link
Member Author

lyrixx commented Apr 30, 2018 •
edited
Loading

There is #27074 pending on the topic, but I'm not sure it fixes your issue actually, can you try it?

  1. It does not solves my issue
  2. It does not work: I had to hardcode my $fileLinkFormat to work on my PR

I don't think the special format has been introduced in 2.7, could you please check?

Indeed. I updated the base branch (3.4)

@lyrixx lyrixx changed the base branch from 2.7 to 3.4 April 30, 2018 12:41
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 30, 2018
@nicolas-grekas
Copy link
Member

commit borrowed in #27074

@lyrixx lyrixx deleted the debug-parse-error-link branch May 3, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Debug Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.