[SecurityBundle] Add missing argument to security.authentication.provider.simple #26774
Conversation
|
A test case would be well deserved, adding a |
| @@ -210,6 +210,7 @@ | ||
| <argument /> <!-- Simple Authenticator --> | ||
| <argument /> <!-- User Provider --> | ||
| <argument /> <!-- Provider-shared Key --> | ||
| <argument>null</argument> <!-- UserChecker --> |
There was a problem hiding this comment.
do we need null? just wondering as its not consistent with the arguments above 😄
There was a problem hiding this comment.
Ah I see @nicolas-grekas added it originally: #26762 (comment)
Still needed now with your fix?
There was a problem hiding this comment.
It is not needed for the fix, but it would be inconsistent not to add it since it is a default parameter.
|
@chalasr I was looking into it. Not sure how I would actually do that. If you can point me to documentation on this part it would be much helpful. Otherwise, I must dig deep into test organization in order to figure out what to do. |
|
@i3or1s Just pushed a test on your branch :) |
|
rebase done, travis failure unrelated (Finder). |
|
Thank you @i3or1s. |
…cation.provider.simple (i3or1s, chalasr) This PR was merged into the 2.8 branch. Discussion ---------- [SecurityBundle] Add missing argument to security.authentication.provider.simple | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26753 | License | MIT | Doc PR | - Created PR in relation to a conversation in [PR](#26762) #26762 Commits ------- c82c2f1 [SecurityBundle] Add test for simple authentication config 1b26aac [SecurityBundle] Add missing argument to security.authentication.provider.simple
Created PR in relation to a conversation in PR #26762