Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Workflow][Registry] Added a new 'all' method (Symfony 3.4) #26659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Workflow][Registry] Added a new 'all' method (Symfony 3.4) #26659

wants to merge 1 commit into from

Conversation

alexpozzi
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Same as 26656 but for the 3.4 version.

@linaori
Copy link
Contributor

linaori commented Mar 23, 2018

@alexpozzi the way Symfony handles versions, means new feature only get merged in new feature releases (next one is 4.1, the master branch). That means this feature won't be back-ported (or added) to 3.4. It looks like your other PR is (almost) ready to be merged though, so you should be able to use this feature in about 2~3 months with 4.1.

@alexpozzi
Copy link
Contributor Author

Ok, no problem.
I submitted it because reading this document I thought it was going to be an accepted change.

Thanks!

@linaori
Copy link
Contributor

linaori commented Mar 23, 2018

If it would considered a bug fix, this branch would've been correct and it could be merged upwards (3.4 to master), so only 1 PR would be required to reduce overhead for the contribution

@alexpozzi
Copy link
Contributor Author

Ah I misread! Sorry for that!

@alexpozzi alexpozzi closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.