[Workflow] removed bc break #26615
Merged
[Workflow] removed bc break #26615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Mar 21, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | |
| Tests pass? | yes |
| Fixed tickets | #26076 |
| License | MIT |
| Doc PR |
xabbuh
reviewed
Mar 21, 2018
| { | ||
| return !$this->transitionBlockerList->isEmpty(); | ||
| } | ||
|
|
||
| public function setBlocked(bool $blocked): void | ||
| public function setBlocked(bool $blocked) |
There was a problem hiding this comment.
the argument type hint needs to be removed too
There was a problem hiding this comment.
🤦♂️ Good catch. Sorry about this waste of time.
a5300cc to
685695d
Compare
xabbuh
approved these changes
Mar 21, 2018
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Mar 21, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [Workflow] removed bc break | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | | Tests pass? | yes | Fixed tickets | #26076 | License | MIT | Doc PR | Commits ------- 685695d [Workflow] removed bc break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.