[DI] Do not suggest writing an implementation when multiple exist #26595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chalasr much better! If I may, I'd like to propose another tweak to your latest proposal: |
| @@ -455,10 +455,11 @@ private function createTypeNotFoundMessage(TypedReference $reference, $label) | ||
|
|
||
| $message = sprintf('has type "%s" but this class %s.', $type, $parentMsg ? sprintf('is missing a parent class (%s)', $parentMsg) : 'was not found'); | ||
| } else { | ||
| $alternatives = $this->createTypeAlternatives($reference); | ||
| $message = $this->container->has($type) ? 'this service is abstract' : 'no such service exists'; | ||
| $message = sprintf('references %s "%s" but %s.%s', $r->isInterface() ? 'interface' : 'class', $type, $message, $this->createTypeAlternatives($reference)); |
There was a problem hiding this comment.
$alternatives to be used on this line, no need to call createTypeAlternatives twice
| } | ||
|
|
||
| $this->assertNotNull($e); | ||
| $this->assertSame('Cannot autowire service "setter_injection_collision": argument "$collision" of method "Symfony\Component\DependencyInjection\Tests\Compiler\SetterInjectionCollision::setMultipleInstancesForOneArg()" references interface "Symfony\Component\DependencyInjection\Tests\Compiler\CollisionInterface" but no such service exists. You should maybe alias this interface to one of these existing services: "c1", "c2".', $e->getMessage()); |
There was a problem hiding this comment.
What's the difference with the previous way this test was written?
This one doesn't tell about Did you create...
There was a problem hiding this comment.
@expectedExceptionMessage uses assertContains IIRC
376ee1c to
1ffdb50
Compare
|
@javiereguiluz Not that I dislike your suggestion, but it applies for interfaces only whereas this code deals with classes as well and I'm just not in the mood for adding more conditions into it. This PR removes a bad suggestion, please feel free to improve the correct one in another :) Ready on my side. |
javiereguiluz
approved these changes
Mar 29, 2018
nicolas-grekas
approved these changes
Mar 29, 2018
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 29, 2018
…e exist (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Do not suggest writing an implementation when multiple exist | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Before: > Cannot autowire service "App\Decorator2": argument "$inner" of method "__construct()" references interface "App\SomeInterface" but no such service exists. You should maybe alias this interface to one of these existing services: "App\Decorator1", "App\Decorator2", "App\Original". Did you create a class that implements this interface? After: > Cannot autowire service "App\Decorator2": argument "$inner" of method "__construct()" references interface "App\SomeInterface" but no such service exists. You should maybe alias this interface to one of these existing services: "App\Decorator1", "App\Decorator2", "App\Original". Commits ------- 1ffdb50 [DI] Do not suggest writing an implementation when multiple exist
nicolas-grekas
added a commit
that referenced
this pull request
Apr 3, 2018
…bbuh) This PR was merged into the 4.1-dev branch. Discussion ---------- [DependencyInjection] fix expected exception message | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Updates a test that was introduced in #25631 to match the changes made in #26595. Commits ------- 042eb4f fix expected exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: