[Debug] Reset previous exception handler earlier to prevent infinite loop #26568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Mar 16, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26438 |
| License | MIT |
| Doc PR | - |
|
Appveyor build has some unrelated failures, but also it's failing on my regression test: https://ci.appveyor.com/project/fabpot/symfony/build/1.0.34059#L1515 It's not calling back the third party exception handler... strange! |
This was referenced Mar 17, 2018
25eea44 to
708de1f
Compare
708de1f to
e83d27b
Compare
e83d27b to
f7e1bb0
Compare
|
For some reason I cannot understand, the integration test fails on Windows (but not locally). |
|
It's now failing on both CI 😢 |
|
@Jean85 for unrelated reasons, keep cool :) |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 19, 2018
…t infinite loop (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] Reset previous exception handler earlier to prevent infinite loop | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26438 | License | MIT | Doc PR | - Commits ------- f7e1bb0 [Debug] Reset previous exception handler ealier to prevent infinite loop
This was referenced Apr 2, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.