Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DomCrawler] Change bad wording in ChoiceFormField::untick #26548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2018
Merged

[DomCrawler] Change bad wording in ChoiceFormField::untick #26548

merged 1 commit into from
Mar 16, 2018

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Mar 15, 2018

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

s/tick/untick/

@rpkamp
Copy link
Contributor

rpkamp commented Mar 16, 2018

LGTM

@javiereguiluz javiereguiluz added this to the 2.7 milestone Mar 16, 2018
@nicolas-grekas
Copy link
Member

Thank you @dunglas.

@nicolas-grekas nicolas-grekas merged commit a4ec6d3 into symfony:2.7 Mar 16, 2018
nicolas-grekas added a commit that referenced this pull request Mar 16, 2018
@nicolas-grekas
bug #26548 [DomCrawler] Change bad wording in ChoiceFormField::untick…
df6024d 
… (dunglas)

This PR was merged into the 2.7 branch.

Discussion
----------

[DomCrawler] Change bad wording in ChoiceFormField::untick

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

s/tick/untick/

Commits
-------

a4ec6d3 [DomCrawler] Change bad wording in ChoiceFormField::untick
This was referenced Apr 2, 2018
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug DomCrawler Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@dunglas @rpkamp @nicolas-grekas @javiereguiluz @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.