[SecurityBundle] Make extra character non mandatory in regex #26424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra character was introduced in 5f9471e, and breaks the testsuite in native php 7.2.
chalasr
approved these changes
Mar 6, 2018
|
Thanks @DavidPrevot. |
chalasr
added a commit
that referenced
this pull request
Mar 6, 2018
…egex (DavidPrevot) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Make extra character non mandatory in regex The extra character was introduced in 5f9471e, and breaks the testsuite in native php 7.2. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 44b4fc8 [SecurityBundle] Make extra character non mandatory in regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra character was introduced in 5f9471e, and breaks the testsuite
in native php 7.2.