[Debug] Keep previous errors of Error instances #26338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like GitHub won't easily let me propose this for the |
|
This PR needs a descriptive title. |
|
Sorry about the PR title. The CI failure on one of three PHP versions seems unrelated, I don't think my change causes a segmentation fault. |
fabpot
approved these changes
Feb 28, 2018
|
Thank you @Philipp91. |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2018
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #26338). Discussion ---------- [Debug] Keep previous errors of Error instances | Q | A | ------------- | --- | Branch? | 2.7 (I have tested against 4.0, but I guess it applies to all the older versions too) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | ? | Fixed tickets | -- | License | MIT Passing on the previous exception gives developers better debugging information. In particular, if you throw an uncaught `new \Error("Something", 0, new \Exception("Inner exception"))` or sth. like that today, you will not see the "Inner exception" text (which may be more helpful than the outer error) in the HTTP debug response. Converting exceptions into errors this way is a common pattern when an exception raised in a sub-routine cannot reasonably occur for a specific caller situation, so there it becomes an `AssertionError` instead. Commits ------- b1b6093 Pass on previous exception in FatalThrowableError
This was referenced Feb 28, 2018
Closed
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing on the previous exception gives developers better debugging information. In particular, if you throw an uncaught
new \Error("Something", 0, new \Exception("Inner exception"))or sth. like that today, you will not see the "Inner exception" text (which may be more helpful than the outer error) in the HTTP debug response. Converting exceptions into errors this way is a common pattern when an exception raised in a sub-routine cannot reasonably occur for a specific caller situation, so there it becomes anAssertionErrorinstead.