Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Config] Introduce BuilderAwareInterface #26308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Config] Introduce BuilderAwareInterface #26308

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7a2259
[Config] Introduce BuilderAwareInterface
ro0NL Feb 25, 2018
d856eb9
Update BuilderAwareInterface.php
ro0NL Feb 26, 2018
d83decb
Update BuilderAwareInterface.php
ro0NL Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions 25 src/Symfony/Component/Config/Definition/Builder/BuilderAwareInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Config\Definition\Builder;

/**
* An interface that can be implemented by nodes which built other nodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/built/build

*
* @author Roland Franssen <franssen.roland@gmail.com>
*/
interface BuilderAwareInterface
{
/**
* Sets a custom children builder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really needed :p ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be just comment, and not phpdoc IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only moved things around, https://github.com/symfony/symfony/pull/26335/files#diff-b579be54110e0018ae82a55725bc373fL49

works for me as is :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use phpdoc for documenting methods, not wild comments. So it's either a docblock or nothing at all, personally I would remove it as it does not bring much IMHO.

*/
public function setBuilder(NodeBuilder $builder);
}
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/Config/Definition/Builder/NodeBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public function node($name, $type)
*/
public function append(NodeDefinition $node)
{
if ($node instanceof ParentNodeDefinitionInterface) {
if ($node instanceof BuilderAwareInterface) {
$builder = clone $this;
$builder->setParent(null);
$node->setBuilder($builder);
Expand Down
4 changes: 1 addition & 3 deletions 4 src/Symfony/Component/Config/Definition/Builder/ParentNodeDefinitionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@
*
* @author Victor Berchet <victor@suumit.com>
*/
interface ParentNodeDefinitionInterface
interface ParentNodeDefinitionInterface extends BuilderAwareInterface
{
public function children();

public function append(NodeDefinition $node);

public function setBuilder(NodeBuilder $builder);
}
Morty Proxy This is a proxified and sanitized view of the page, visit original site.