[FrameworkBundle] [Console] add a warning when command is not found

symfony · fabpot · Feb 27, 2018 · Feb 23, 2018 · Feb 25, 2018 · efd8f7fa3aa5492b7c3a326c5387f3bbf1daf190
commit efd8f7fa3aa5492b7c3a326c5387f3bbf1daf190
diff --git a/src/Symfony/Bundle/FrameworkBundle/Console/Application.php b/src/Symfony/Bundle/FrameworkBundle/Console/Application.php
@@ -65,6 +65,8 @@ public function doRun(InputInterface $input, OutputInterface $output)

        $this->setDispatcher($this->kernel->getContainer()->get('event_dispatcher'));

+        $this->registerCommands();
+
        if ($this->registrationErrors) {
            $this->renderRegistrationErrors($input, $output);
        }

diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Console/ApplicationTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Console/ApplicationTest.php
@@ -165,6 +165,33 @@ public function testRunOnlyWarnsOnUnregistrableCommand()
        $this->assertContains('fine', $output);
    }

+    public function testRegistrationErrorsAreDisplayedOnCommandNotFound()
+    {
+        $container = new ContainerBuilder();
+        $container->register('event_dispatcher', EventDispatcher::class);
+
+        $kernel = $this->getMockBuilder(KernelInterface::class)->getMock();
+        $kernel
+            ->method('getBundles')
+            ->willReturn(array($this->createBundleMock(
+                array((new Command(null))->setCode(function (InputInterface $input, OutputInterface $output) { $output->write('fine'); }))
+            )));
+        $kernel
+            ->method('getContainer')
+            ->willReturn($container);
+
+        $application = new Application($kernel);
+        $application->setAutoExit(false);
+
+        $tester = new ApplicationTester($application);
+        $tester->run(array('command' => 'fine'));
+        $output = $tester->getDisplay();
+
+        $this->assertSame(1, $tester->getStatusCode());
+        $this->assertContains('Some commands could not be registered:', $output);
+        $this->assertContains('Command "fine" is not defined.', $output);
+    }
+
    private function getKernel(array $bundles, $useDispatcher = false)
    {
        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerInterface')->getMock();