[Console] Suppress warning from sapi_windows_vt100_support #26211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 17, 2018
chalasr
requested changes
Feb 18, 2018
| @@ -450,7 +450,7 @@ protected function supportsColors() | ||
|
|
||
| if ('\\' === DIRECTORY_SEPARATOR) { | ||
| static::$defaultColors = @( | ||
| function_exists('sapi_windows_vt100_support') && sapi_windows_vt100_support($this->outputStream) | ||
| function_exists('sapi_windows_vt100_support') && @sapi_windows_vt100_support($this->outputStream) |
chalasr
approved these changes
Feb 18, 2018
|
Thanks for fixing this bug and congratz for your first contribution to Symfony @adawolfa. |
chalasr
pushed a commit
that referenced
this pull request
Feb 18, 2018
… (adawolfa) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Suppress warning from sapi_windows_vt100_support | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26210 | License | MIT Suppresses warning from `sapi_windows_vt100_support()` for non-STDIO streams, e. g. `php://memory`. Commits ------- 43f9421 Suppress warning from sapi_windows_vt100_support on stream other than STDIO
This was referenced Feb 28, 2018
Closed
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses warning from
sapi_windows_vt100_support()for non-STDIO streams, e. g.php://memory.