Env var maps to undefined constant. #26112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I try to use a constant as an environment variable, as described in the blog item, I run into the following problem. Env var "SOME_CONST" maps to undefined constant "App\\Util\\SomeClass::SOME_CONST". The proposed solution works for me, however, I'm not sure if this is the best and conform Symfony standards. Blog: https://symfony.com/blog/new-in-symfony-3-4-advanced-environment-variables
nicolas-grekas
approved these changes
Feb 9, 2018
| @@ -111,11 +111,13 @@ public function getEnv($prefix, $name, \Closure $getEnv) | ||
| } | ||
|
|
||
| if ('const' === $prefix) { | ||
| $env = \str_replace("\\\\","\\", $env); |
There was a problem hiding this comment.
this should be removed (the blog post has a typo, the \ should not be doubled there, we're going to fix it)
There was a problem hiding this comment.
We've tested here with and without the double \ but we could not get it to work.
The original scripts runs: return constant($name);
While I only could get it to work with: return constante($env);
Will this be fixted to? Or are we doing something wrong?
|
@dsmink we've just fixed the blog post ... but we'll need to wait a bit until caches are regenerated. Thanks. |
|
@javiereguiluz @nicolas-grekas Thanks guys! |
|
Thank you @dsmink. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 9, 2018
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #26112). Discussion ---------- Env var maps to undefined constant. When I try to use a constant as an environment variable, as described in the blog item, I run into the following problem. Env var "SOME_CONST" maps to undefined constant "App\\Util\\SomeClass::SOME_CONST". The proposed solution works for me, however, I'm not sure if this is the best and conform Symfony standards. Blog: https://symfony.com/blog/new-in-symfony-3-4-advanced-environment-variables | Q | A | ------------- | --- | Branch? | master for features / 2.7 up to 4.0 for bug fixes <!-- see below --> | Bug fix? | yes/no | New feature? | yes/no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | yes/no | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes/no | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Replace this comment by a description of what your PR is solving. --> Commits ------- bdf9efc Env var maps to undefined constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to use a constant as an environment variable, as described in the blog item,
I run into the following problem.
Env var "SOME_CONST" maps to undefined constant "App\Util\SomeClass::SOME_CONST".
The proposed solution works for me, however, I'm not sure if this is the best and conform Symfony standards.
Blog:
https://symfony.com/blog/new-in-symfony-3-4-advanced-environment-variables