[Cache][WebProfiler][3.3] fix collecting cache stats with sub-requests #26080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing sub-requests the
CacheDataCollector
will get the calls from theTraceableAdapter
per request. So calling it multiple times was always overwriting the previously collected calls with the latest calls.So when no cache calls were performed during a sub-request all collected calls from the master request were just lost and the panel did not show anything.
@Nyholm seems you added this specific code? What was the motivation to clear directly after getting the calls? Just prevent a memory leak?
As of 3.4+ there is a reset method and with this additional changeset we can therefore easily reset the
TraceableAdapter
?See PR for 3.4+: #26082