[YAML] Issue #26065: leading spaces in YAML multi-line string literals #26067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96b2bde to
21f23e6
Compare
…g literals When dumping an object to YAML. If the first line of a mult-line string literal starts with spaces then the YAML spec says you need to use a [block indentation indicator][1]. [1]: http://www.yaml.org/spec/1.2/spec.html#id2793979
When dumping YAML: When the first line of a multi-line string literal starts with a space, emit a block indentation indicator. As per spec at: http://www.yaml.org/spec/1.2/spec.html#id2793979 Issue symfony#26065
21f23e6 to
272fe5a
Compare
xabbuh
approved these changes
Feb 8, 2018
|
Thank you @tamc. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 11, 2018
…ing literals (tamc) This PR was squashed before being merged into the 3.4 branch (closes #26067). Discussion ---------- [YAML] Issue #26065: leading spaces in YAML multi-line string literals | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26065 | License | MIT | Doc PR | no Doing this: Yaml::dump( ["text" => " leading space in first line\nno leading space in last line\n"], 2, 4, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK ); Will produce this: text: | leading space in first line no leading space in last line Which is invalid YAML because when the first line has leading spaces it needs a [block indentation indicator](http://www.yaml.org/spec/1.2/spec.html#id2793979) like this: text: |4 leading space in first line no leading space in last line This pull requests contains a test and a patch. Commits ------- aa95663 [YAML] Issue #26065: leading spaces in YAML multi-line string literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this:
Will produce this:
Which is invalid YAML because when the first line has leading spaces it needs a block indentation indicator like this:
This pull requests contains a test and a patch.