[DI][Routing] Fix tracking of globbed resources #25989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New classes should have tests |
weaverryan
reviewed
Feb 1, 2018
| { | ||
| foreach ($this->glob($resource, false, $globResource) as $path => $info) { | ||
| $this->import($path); | ||
| } |
There was a problem hiding this comment.
We don't need any of the parent class's special glob code that's in import? I don't fully understand that code - it came from #22985 - but I know you do ;). Just double-checking.
There was a problem hiding this comment.
The parent extra logic is here to autodetect glob when it's not explicit. Here, it is explicit, so no need.
|
@stof with tests 👍 |
nicolas-grekas
commented
Feb 1, 2018
|
Votes pending |
weaverryan
approved these changes
Feb 2, 2018
|
Thank you @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 4, 2018
…rekas, sroze) This PR was merged into the 3.4 branch. Discussion ---------- [DI][Routing] Fix tracking of globbed resources | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25904 | License | MIT | Doc PR | - The current `GlobFileLoader` in `Config` misses resource tracking, so we can't use it and have to use a per-component one instead. (deps=high failures will be fixed after merging up to master.) Commits ------- 945c753 Add tests for glob loaders ad98c1f [DI][Routing] Fix tracking of globbed resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
GlobFileLoaderinConfigmisses resource tracking, so we can't use it and have to use a per-component one instead.(deps=high failures will be fixed after merging up to master.)