[Debug] Fix bad registration of exception handler, leading to mem leak #25971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jan 30, 2018
| Q | A |
|---|---|
| Branch? | 27 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25965 |
| License | MIT |
| Doc PR | - |
This was referenced Jan 30, 2018
|
@nicolas-grekas I applied your commit on 3.4.4 in my projects and it fixes the problems I've been having since moving to 3.4.4 👍 |
|
With your patch applied, the leak seems to be gone. |
fabpot
approved these changes
Feb 1, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 1, 2018
… to mem leak (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] Fix bad registration of exception handler, leading to mem leak | Q | A | ------------- | --- | Branch? | 27 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25965 | License | MIT | Doc PR | - Commits ------- 926b1be [Debug] Fix bad registration of exception handler, leading to mem leak
|
Any chance this could be tagged ASAP since it consumes a lot of resources? |
|
I ran into this issue today and couldn't find the bugfix in the tag 3.4.4. Is there any update plan for the tags? |
|
@florian25686 The bugfix will go into 3.4.5. |
This was referenced Feb 28, 2018
Closed
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.