Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Form] Fixed Button::setParent() when already submitted #25926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 4 src/Symfony/Component/Form/Button.php
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ public function offsetUnset($offset)
*/
public function setParent(FormInterface $parent = null)
{
if ($this->submitted) {
throw new AlreadySubmittedException('You cannot set the parent of a submitted button');
}

$this->parent = $parent;
}

Expand Down
20 changes: 18 additions & 2 deletions 20 src/Symfony/Component/Form/Tests/ButtonTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,34 @@ protected function setUp()
$this->factory = $this->getMockBuilder('Symfony\Component\Form\FormFactoryInterface')->getMock();
}

/**
* @expectedException \Symfony\Component\Form\Exception\AlreadySubmittedException
*/
public function testSetParentOnSubmittedButton()
{
$button = $this->getButtonBuilder('button')
->getForm()
;

$button->submit('');

$button->setParent($this->getFormBuilder('form')->getForm());
}

/**
* @dataProvider getDisabledStates
*/
public function testDisabledIfParentIsDisabled($parentDisabled, $buttonDisabled, $result)
{
$form = $this->getFormBuilder('form')
->setDisabled($parentDisabled)
->getForm();
->getForm()
;

$button = $this->getButtonBuilder('button')
->setDisabled($buttonDisabled)
->getForm();
->getForm()
;

$button->setParent($form);

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.