Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[FrameworkBundle] revert useless tests fixtures changes #25890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
revert useless tests fixtures changes
This will revert #25847. Basically, the changes done in #25847 were not
wrong per se. However, those changes were not necessary as the tests
were not failing because of the missing "assets" config, but due to an
issue introduced in the Config component. Furthermore, removing this
part of the config fixtures gives us the benefit that our before
normalization logic that enables assets support when the templating
integration is enabled is properly tested.
  • Loading branch information
xabbuh committed Jan 22, 2018
commit fb1be51a5c4f3ea8f09ed0af93d29d38a534557e
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<?php

$container->loadFromExtension('framework', array(
'assets' => array(
'enabled' => true,
),
'templating' => array(
'engines' => array('php', 'twig'),
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd">

<framework:config>
<framework:assets enabled="true" />
<framework:templating>
<framework:engine>php</framework:engine>
<framework:engine>twig</framework:engine>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
framework:
assets:
enabled: true
templating:
engines: [php, twig]
Morty Proxy This is a proxified and sanitized view of the page, visit original site.