[Routing] Make sure we only build routes once #25791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've pressed [enter] to quick... can some of you remove the "Deprecation" and "BC Break" labels please? Also, fabbot's review is false-positive. |
832c530 to
927a75a
Compare
|
Thanks @javiereguiluz. The failure is HHVM and is not related. |
xabbuh
approved these changes
Jan 15, 2018
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Jan 16, 2018
This PR was merged into the 3.3 branch. Discussion ---------- [Routing] Make sure we only build routes once | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25746 | License | MIT | Doc PR | ø We need to build the collection(s) only once, else the prefix would be duplicated. Commits ------- 927a75a Make sure we only build once and have one time the prefix when importing routes
This was referenced Jan 29, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to build the collection(s) only once, else the prefix would be duplicated.