Use triggering file to determine weak vendors if when the test is run in a separate process #25685
Conversation
|
can you rebase on 3.4 please ? |
… in a separate process
4f05ef4 to
14925cb
Compare
|
Rebased on 3.4. I can't work out how to write a test for this because atm all the weak vendor stuff is tested via phpt tests and a fake vendor. |
| @@ -121,6 +121,7 @@ public static function register($mode = 0) | ||
| $msg = $parsedMsg['deprecation']; | ||
| $class = $parsedMsg['class']; | ||
| $method = $parsedMsg['method']; | ||
| $isWeak = DeprecationErrorHandler::MODE_WEAK === $mode || (DeprecationErrorHandler::MODE_WEAK_VENDORS === $mode && $isVendor = $inVendors($parsedMsg['triggering_file'])); |
There was a problem hiding this comment.
shouldn't $isVendor be initialized to false before this line?
There was a problem hiding this comment.
then L124: $isWeak = $isWeak || ...?
There was a problem hiding this comment.
self answering :)
shouldn't $isVendor be initialized to false before this line?
not needed as logically this wouldn't make a difference, but might still help the reader
then L124: $isWeak = $isWeak || ...?
really not sure about that (might instead break the fix, you'll tell :) )
There was a problem hiding this comment.
Yeah that'd break the fix. The point is $isWeak is wrong at this point. Can always add a comment.
|
Thank you @alexpott. |
|
Oh wow you fixed it, thanks! Could have pinged me though :P |
| // then we need to use the serialized information to | ||
| // determine if the error has been triggered from vendor | ||
| // code. | ||
| $isWeak = DeprecationErrorHandler::MODE_WEAK === $mode || (DeprecationErrorHandler::MODE_WEAK_VENDORS === $mode && $isVendor = $inVendors($parsedMsg['triggering_file'])); |
Uh oh!
There was an error while loading. Please reload this page.