Dumper shouldn't use html format for phpdbg #25662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jan 3, 2018
|
In other parts of Symfony we have this: in_array(PHP_SAPI, array('cli', 'cli-server', 'phpdbg'))Should we use the same here? |
|
@javiereguiluz cli-server means HTML should be used |
|
Thank you @jhoff. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 3, 2018
…jhoff) This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #25662). Discussion ---------- Dumper shouldn't use html format for phpdbg / cli-server | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This may not be the lowest branch that this fix applies to. Prevents the dumper from outputting in html format when using phpdbg. Commits ------- e2b6091 Dumper shouldn't use html format for phpdbg
|
Awesome. Also, sorry, I originally had cli-server in there but decided to take it out for the reason stated above. I then forgot to edit the title of the merge request. |
This was referenced Jan 5, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be the lowest branch that this fix applies to.
Prevents the dumper from outputting in html format when using phpdbg.