Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Lock] Add MysqlStore that use GET_LOCK #25578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[Lock] Add MysqlStore that use GET_LOCK #25578

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2a944df
[Lock] Add MysqlStore that use GET_LOCK
GromNaN Dec 22, 2017
4408fc6
Configure travis for MysqlStore
GromNaN Dec 23, 2017
74bf72e
Load PDO Mysql in appveyor for Lock MysqlStore
GromNaN Dec 27, 2017
828ac17
[Lock] Inject and reuse a PDO or DBAL connection in MysqlStore
GromNaN Dec 28, 2017
2b1a0e5
[Lock] Use distinct store for forked processes
GromNaN Dec 28, 2017
c0f10a4
[Lock] Enable mysql service on appveyor
GromNaN Dec 28, 2017
7334a1f
[Lock] Set the session timeout from the TTL
GromNaN Dec 29, 2017
51e5e7f
Don't store the prepared statement in the lock key
GromNaN Jan 19, 2018
1a0946c
The wait timeout should be for non-blocking lock
GromNaN Jan 19, 2018
3ae4cce
Check if lock still exists with a db query
GromNaN Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check if lock still exists with a db query
  • Loading branch information
@GromNaN
GromNaN committed Jan 19, 2018
commit 3ae4cceea667cbdc2ccff4a122be52d8bbc4f04c
21 changes: 16 additions & 5 deletions 21 src/Symfony/Component/Lock/Store/MysqlStore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function __construct($connection, $waitTimeout = 0)
}

$this->connection = $connection;
$this->waitTimeout = (int) $waitTimeout;
$this->waitTimeout = $waitTimeout;
}

/**
Expand Down Expand Up @@ -130,9 +130,9 @@ public function delete(Key $key)

$storedKey = $key->getState(__CLASS__);

$releaseStmt = $this->connection->prepare('DO RELEASE_LOCK(:key)');
$releaseStmt->bindValue(':key', $storedKey, \PDO::PARAM_STR);
$releaseStmt->execute();
$stmt = $this->connection->prepare('DO RELEASE_LOCK(:key)');
$stmt->bindValue(':key', $storedKey, \PDO::PARAM_STR);
$stmt->execute();

$key->removeState(__CLASS__);
}
Expand All @@ -142,6 +142,17 @@ public function delete(Key $key)
*/
public function exists(Key $key)
{
return $key->hasState(__CLASS__);
if (!$key->hasState(__CLASS__)) {
return false;
}

$storedKey = $key->getState(__CLASS__);

$stmt = $this->connection->prepare('SELECT IF(IS_USED_LOCK(:key) = CONNECTION_ID(), 1, 0)');
Copy link
Member Author

@GromNaN GromNaN Jan 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jderusse This query insure that: 1. the connection is still alive & 2. the lock is still assigned to the current connection.

$stmt->bindValue(':key', $storedKey, \PDO::PARAM_STR);
$stmt->setFetchMode(\PDO::FETCH_COLUMN, 0);
$stmt->execute();

return '1' === $stmt->fetchColumn();
}
}
Morty Proxy This is a proxified and sanitized view of the page, visit original site.