[2.7][DX] Use constant message contextualisation for deprecations #25565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 20, 2017
javiereguiluz
approved these changes
Dec 20, 2017
|
I agree that this makes the message easier to use. |
xabbuh
approved these changes
Dec 22, 2017
chalasr
approved these changes
Dec 30, 2017
fabpot
approved these changes
Dec 31, 2017
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Dec 31, 2017
…recations (romainneutron) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][DX] Use constant message contextualisation for deprecations | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes Since many projects are using this mechanism for deprecating feature, it is sometimes difficult to understand which vendor triggers a deprecation. Sometimes we're using `since Symfony x.y` format, sometimes we are using `since x.y`. I propose to always use `since Symfony x.y` format. Commits ------- c2338cb [2.7][DX] Use constant message contextualisation for deprecations
fabpot
added a commit
that referenced
this pull request
Dec 31, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Fix some deprecation messages | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Some messages were forgotten in #25565 Commits ------- dc55456 fixed some deprecation messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since many projects are using this mechanism for deprecating feature, it is sometimes difficult to understand which vendor triggers a deprecation.
Sometimes we're using
since Symfony x.yformat, sometimes we are usingsince x.y. I propose to always usesince Symfony x.yformat.