[WebProfilerBundle] Fix panel break when stopwatch component is not installed. #25526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% set subrequests_time = subrequests_time + child.getcollector('time').events.__section__.duration %} | ||
| {% endfor %} | ||
| {% else %} | ||
| {% set subrequests_time = 0 %} |
There was a problem hiding this comment.
The profiler panel shows 0 for all time values, only the toolbar shows n/a. I can change it to be n/a for all values if you like it better. WDYT?
Simperfit
approved these changes
Dec 19, 2017
javiereguiluz
approved these changes
Dec 28, 2017
|
@umulmrum thanks for fixing this bug and congrats on your first Symfony contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Dec 28, 2017
…nt is not installed. (umulmrum, javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [WebProfilerBundle] Fix panel break when stopwatch component is not installed. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25350 | License | MIT | Doc PR | - Fixes a crash in the time profiler panel when the stopwatch is not installed. This avoids a hard dependency like the ticket author requested, as the rest of the component can already deal with that case. I think this is an issue in 3.4+, but I only tested against 4.0.2 locally (code in the affected file only differs in whitespace between 3.4 and 4.0). Commits ------- e9577cb Display n/a for sub-requests time when Stopwatch component is not installed 410b597 Fix panel break when stopwatch component is not installed.
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…component is not installed. (umulmrum, javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [WebProfilerBundle] Fix panel break when stopwatch component is not installed. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#25350 | License | MIT | Doc PR | - Fixes a crash in the time profiler panel when the stopwatch is not installed. This avoids a hard dependency like the ticket author requested, as the rest of the component can already deal with that case. I think this is an issue in 3.4+, but I only tested against 4.0.2 locally (code in the affected file only differs in whitespace between 3.4 and 4.0). Commits ------- e9577cb Display n/a for sub-requests time when Stopwatch component is not installed 410b597 Fix panel break when stopwatch component is not installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash in the time profiler panel when the stopwatch is not installed. This avoids a hard dependency like the ticket author requested, as the rest of the component can already deal with that case.
I think this is an issue in 3.4+, but I only tested against 4.0.2 locally (code in the affected file only differs in whitespace between 3.4 and 4.0).