Preserve percent-encoding in URLs when performing redirects in the UrlMatcher #25427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check the failures please? |
|
fabbot complains about fixtures ( |
|
Overall, would it be better to apply |
Simperfit
approved these changes
Dec 12, 2017
fabpot
approved these changes
Dec 14, 2017
|
Thank you @mpdude. |
fabpot
added a commit
that referenced
this pull request
Dec 14, 2017
…s in the UrlMatcher (mpdude) This PR was squashed before being merged into the 2.7 branch (closes #25427). Discussion ---------- Preserve percent-encoding in URLs when performing redirects in the UrlMatcher | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While investigating #25373, I found that when the *dumped* `UrlMatcher` performs redirections due to missing trailing slashes on URLs, it does so using an url*de*coded URL. This is wrong, as it may lead to wrong interpretations of URLs upon the next request. For example, think of an URL that contains `%23` in the middle of the path info. Upon redirection, this will be turned into `#` with an obvious effect. Commits ------- 8146510 Preserve percent-encoding in URLs when performing redirects in the UrlMatcher
|
@mpdude Can you have a look at why the tests are broken on 3.4 (https://travis-ci.org/symfony/symfony/jobs/316592496)? Thanks. |
|
Tests fixed in 3c67741 |
This was referenced Jan 5, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #25373, I found that when the dumped
UrlMatcherperforms redirections due to missing trailing slashes on URLs, it does so using an urldecoded URL.This is wrong, as it may lead to wrong interpretations of URLs upon the next request. For example, think of an URL that contains
%23in the middle of the path info. Upon redirection, this will be turned into#with an obvious effect.