[Console] Commands with an alias should not be recognized as ambiguous #25407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstok
reviewed
Dec 9, 2017
|
|
||
| return $commandName === $nameOrAlias || !in_array($commandName, $commands); | ||
| }); | ||
| } | ||
|
|
||
| $exact = in_array($name, $commands, true); | ||
| if (count($commands) > 1 && !$exact) { | ||
| if (count($commands) > 1 && !$exact && !isset($aliases[$name])) { |
There was a problem hiding this comment.
Maybe move the isset to the beginning as it's faster then count? - Micro optimization.
1f1e54c to
cb9f6ff
Compare
chalasr
reviewed
Dec 15, 2017
|
|
||
| return $commandName === $nameOrAlias || !in_array($commandName, $commands); | ||
| }); | ||
| } | ||
|
|
||
| $exact = in_array($name, $commands, true); | ||
| if (count($commands) > 1 && !$exact) { | ||
| if (!isset($aliases[$name]) && count($commands) > 1 && !$exact) { |
There was a problem hiding this comment.
changing line 537 to $exact = \in_array($name, $commands, true) || isset($aliases[$name]); would avoid the need for both this check and the condition added below
There was a problem hiding this comment.
it's better ike this ;). Thanks!
cb9f6ff to
863f632
Compare
nicolas-grekas
approved these changes
Dec 20, 2017
chalasr
approved these changes
Dec 22, 2017
|
Thank you @Simperfit. |
chalasr
pushed a commit
that referenced
this pull request
Dec 22, 2017
…as ambiguous (Simperfit) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Commands with an alias should not be recognized as ambiguous | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | no | Fixed tickets | no <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | When having two commands with the same starting name and an alias equal to the starting name, we should not have an ambiguous error because we are setting the alias. Commits ------- 863f632 [Console] Commands with an alias should not be recognized as ambiguous
This was referenced Jan 5, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having two commands with the same starting name and an alias equal to the starting name, we should not have an ambiguous error because we are setting the alias.