[Form] Remove group options without data on debug:form command #25404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Travis failure unrelated) |
|
this will remove also options with a |
@stof no, this is a list of defined options only, i.e they are names (strings). |
|
I just applied your patch, and yes it works. |
|
@maidmaid thanks! |
Simperfit
approved these changes
Dec 9, 2017
|
@yceruto Could you add a test case to prevent regressions? |
2259962 to
083c8af
Compare
|
Test added (still failure is unrelated) |
chalasr
approved these changes
Dec 14, 2017
ogizanagi
approved these changes
Dec 15, 2017
fabpot
approved these changes
Dec 31, 2017
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Dec 31, 2017
…mand (yceruto) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Remove group options without data on debug:form command | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25394 | License | MIT | Doc PR | - This also fix the normalization of the options column for text descriptor, regardless of changes in `collectOptions()` method (which is enough to fix the related bug). @maidmaid could you confirm if these changes solve the problem? Commits ------- 083c8af Remove group options without data and fix normalization
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fix the normalization of the options column for text descriptor, regardless of changes in
collectOptions()method (which is enough to fix the related bug).@maidmaid could you confirm if these changes solve the problem?