[HttpFoundation] Fixed default user-agent (3.X -> 4.X) #25392
Conversation
lyrixx
commented
Dec 8, 2017
| Q | A |
|---|---|
| Branch? | 4.0 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25390 |
| License | MIT |
| Doc PR |
| @@ -312,7 +312,7 @@ public static function create($uri, $method = 'GET', $parameters = array(), $coo | ||
| 'SERVER_NAME' => 'localhost', | ||
| 'SERVER_PORT' => 80, | ||
| 'HTTP_HOST' => 'localhost', | ||
| 'HTTP_USER_AGENT' => 'Symfony/3.X', | ||
| 'HTTP_USER_AGENT' => 'Symfony/4.X', |
There was a problem hiding this comment.
...and the usual question when we do changes like this: can we remove the version number? would it make sense to do that? is it valid as a User Agent string?
There was a problem hiding this comment.
👍 for removing the version
|
Why remove the version number? |
|
Actually I really don't care. I removed it as @javiereguiluz suggested it in order to ease maintenance. |
|
Thank you @lyrixx. |
…rixx) This PR was merged into the 4.0 branch. Discussion ---------- [HttpFoundation] Fixed default user-agent (3.X -> 4.X) | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25390 | License | MIT | Doc PR | Commits ------- ac007e1 [HttpFoundation] Fixed default user-agent (3.X -> 4.X)