Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Bridge/PhpUnit] Prefer $_SERVER['argv'] over $argv #25304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put back some code that was removed for debug purposes.
  • Loading branch information
ricardodevries committed Dec 4, 2017
commit 67cc25360ec5bb7d77fe820d39bffaba9347c557
3 changes: 2 additions & 1 deletion 3 src/Symfony/Bridge/PhpUnit/bin/simple-phpunit
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ if ($components) {
class SymfonyBlacklistSimplePhpunit {}
}
array_splice($_SERVER['argv'], 1, 0, array('--colors=always'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, in fact, this change introduces a bug
both $_SERVER['argv'] and $argv must be updated
this breaks the second


$_SERVER['argv'] = $argv;
$_SERVER['argc'] = ++$argc;
include "$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit";
}

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.