[DI] Cast ids to string, as done on 3.4 #25284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not type hinting the arguments as |
|
Because that'd be a BC break. |
dunglas
approved these changes
Dec 3, 2017
|
We definitely need tests for this one. |
Simperfit
approved these changes
Dec 3, 2017
ro0NL
approved these changes
Dec 3, 2017
|
Thank you @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 4, 2017
…roze) This PR was merged into the 4.0 branch. Discussion ---------- [DI] Cast ids to string, as done on 3.4 | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As reported on slack, we're now missing cast-to-string. This PR puts them explicitly at the places where 3.4 has a call to the removed "normalizeId" method.  Commits ------- 11c6b38 Ensure services & aliases can be referred to with `__toString`able objects 483dd13 [DI] Cast ids to string, as done on 3.4
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on slack, we're now missing cast-to-string.
This PR puts them explicitly at the places where 3.4 has a call to the removed "normalizeId" method.