[DI] Prevent a ReflectionException during cache:clear when the parent class doesn't exist #25160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -378,7 +378,11 @@ private function collectLineage($class, array &$lineage) | ||
| if (isset($lineage[$class])) { | ||
| return; | ||
| } | ||
| if (!$r = $this->container->getReflectionClass($class)) { | ||
| try { | ||
| if (!$r = $this->container->getReflectionClass($class)) { |
There was a problem hiding this comment.
or pass "false" as second argument?
… class doesn't exist
2ff4ae9 to
9d1fdf1
Compare
| namespace Symfony\Component\DependencyInjection\Tests\Fixtures; | ||
|
|
||
| /** | ||
| * @author Kévin Dunglas <dunglas@gmail.com> |
There was a problem hiding this comment.
not sure we need the license + docblock on fixtures ;)
nicolas-grekas
approved these changes
Nov 26, 2017
|
|
||
| $container = new ContainerBuilder(); | ||
|
|
||
| $container->register(HotPath\C1::class)->addTag('container.hot_path')->setPublic(true); | ||
| $container->register(HotPath\C2::class)->addArgument(new Reference(HotPath\C3::class))->setPublic(true); | ||
| $container->register(HotPath\C3::class); | ||
| $container->register(ParentNotExists::class); |
There was a problem hiding this comment.
the service should be public, so that the test is still valid on 4.0
| @@ -98,6 +101,16 @@ protected function getC2Service() | ||
| return $this->services['Symfony\Component\DependencyInjection\Tests\Fixtures\includes\HotPath\C2'] = new \Symfony\Component\DependencyInjection\Tests\Fixtures\includes\HotPath\C2(${($_ = isset($this->services['Symfony\Component\DependencyInjection\Tests\Fixtures\includes\HotPath\C3']) ? $this->services['Symfony\Component\DependencyInjection\Tests\Fixtures\includes\HotPath\C3'] : $this->services['Symfony\Component\DependencyInjection\Tests\Fixtures\includes\HotPath\C3'] = new \Symfony\Component\DependencyInjection\Tests\Fixtures\includes\HotPath\C3()) && false ?: '_'}); | ||
| } | ||
|
|
||
| /** | ||
| * Gets the private 'Symfony\Component\DependencyInjection\Tests\Fixtures\ParentNotExists' shared service. |
|
Thank you @dunglas. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 27, 2017
… the parent class doesn't exist (dunglas) This PR was squashed before being merged into the 3.4 branch (closes #25160). Discussion ---------- [DI] Prevent a ReflectionException during cache:clear when the parent class doesn't exist | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Currently, if you just run the following commands: ``` composer create-project -s beta symfony/skeleton:^3.4 test composer req orm ``` You get the following error: ``` In UniqueEntityValidator.php line 27: [ReflectionException] Class Symfony\Component\Validator\ConstraintValidator not found ``` `UniqueEntityValidator` is in the bridge, but it's parent class is in the validator (that is not installed by default). The hot path optimization feature (enabled by default) uses reflection, and the reflection API throws an exception in this specific case. This PR fixes the error. Commits ------- 6e622c6 [DI] Prevent a ReflectionException during cache:clear when the parent class doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you just run the following commands:
You get the following error:
UniqueEntityValidatoris in the bridge, but it's parent class is in the validator (that is not installed by default). The hot path optimization feature (enabled by default) uses reflection, and the reflection API throws an exception in this specific case.This PR fixes the error.