[DI] Fix handling of inlined definitions by ContainerBuilder #25130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Nov 23, 2017
|
Does that make Behat working with Symfony 3.4 ? |
f45aedc to
c9c18ac
Compare
xabbuh
approved these changes
Nov 23, 2017
Almost. The |
chalasr
approved these changes
Nov 23, 2017
|
Weird. @dunglas do you need a hand? |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 23, 2017
…er (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [DI] Fix handling of inlined definitions by ContainerBuilder | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Team work with @dunglas, debugging behat tests on Symfony 4: now that everything is private, inlining happens quite often on Symfony 4. This made us discover an old bug: inlining makes it possible to share the same definition instance to define a locally shared service (local to one service). This is handled properly in PhpDumper, but ContainerDumper is broken. Here is the fix. Commits ------- c9c18ac [DI] Fix handling of inlined definitions by ContainerBuilder
This was referenced Dec 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team work with @dunglas, debugging behat tests on Symfony 4:
now that everything is private, inlining happens quite often on Symfony 4.
This made us discover an old bug: inlining makes it possible to share the same definition instance to define a locally shared service (local to one service). This is handled properly in PhpDumper, but ContainerDumper is broken. Here is the fix.