[Console] Fix global console flag when used in chain #24987

Simperfit · Nov 16, 2017

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#23876
License	MIT
Doc PR

Because SymfonyCon is great we can create pull request in it ! (this was preparer in the plane and I can push it just right now ;))

Finished in the #SymfonyConHackday2017

chalasr · Nov 16, 2017

For 2.7?

Simperfit · Nov 16, 2017

Yes I will rebase it :) Le jeu. 16 nov. 2017 à 16:18, Robin Chalas <notifications@github.com> a écrit :

…

For 2.7? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24987 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSq8mGwVKCDC_Tw8D0aRjwEFe0DKJ5Rks5s3EQ2gaJpZM4QgEfq> .

ro0NL · Nov 17, 2017

src/Symfony/Component/Console/Input/ArgvInput.php

@@ -168,12 +168,12 @@ private function parseArgument($token)
            $arg = $this->definition->getArgument($c);
            $this->arguments[$arg->getName()] = $arg->isArray() ? array($token) : $token;

-        // if last argument isArray(), append token to last argument
+            // if last argument isArray(), append token to last argument


ro0NL · Nov 17, 2017

src/Symfony/Component/Console/Input/ArgvInput.php

@@ -282,6 +282,14 @@ public function hasParameterOption($values)
                if ($token === $value || 0 === strpos($token, $value.'=')) {
                    return true;
                }
+
+                if (0 === strpos($token, '-') && 0 !== strpos($token, '--')) {


i dont follow it really, but it works 👍

$ bin/console router:match -hq before: exception (missing argument) after: quiet :)

fabpot · Nov 18, 2017

src/Symfony/Component/Console/Input/ArgvInput.php

        } elseif ($this->definition->hasArgument($c - 1) && $this->definition->getArgument($c - 1)->isArray()) {
            $arg = $this->definition->getArgument($c - 1);
            $this->arguments[$arg->getName()][] = $token;

-        // unexpected argument
+            // unexpected argument


chalasr · Nov 26, 2017

Thanks for fixing this bug Hamza.

…erfit) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix global console flag when used in chain | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no  | BC breaks? | no | Deprecations? | no  | Tests pass? | yes | Fixed tickets | #23876 | License | MIT | Doc PR | Because SymfonyCon is great we can create pull request in it ! (this was preparer in the plane and I can push it just right now ;)) Finished in the #SymfonyConHackday2017 Commits ------- 1f8db73 [Console] Fix global console flag when used in chain

Zwartpet · Dec 13, 2017

@fabpot This results in a bug in v2.8.32. When I try to run a command the command is not actually executed but the Symfony shell is opened (same result as with adding the --shell option).
Did not check other releases though.

Simperfit · Dec 13, 2017

I will try to reproduce then fix this behaviour. Could you try to provide a reproducer ? Le mer. 13 déc. 2017 à 15:40, John Zwarthoed <notifications@github.com> a écrit :

…

@fabpot <https://github.com/fabpot> This results in a bug in v2.8.32. When I try to run a command the command is not actually executed but the Symfony shell is opened (same result as with adding the --shell option). Did not check other releases though. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24987 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSq8mpnV9LEOa67zaURyoqxMDk9XbE0ks5s_-HtgaJpZM4QgEfq> .

Zwartpet · Dec 13, 2017

Just running app/console already causes the issue for me (with symfony/console 2.8.32)

Simperfit · Dec 13, 2017

I've just tested with symfony/console 2.8.32 and I can't reproduce the problem :

  - Updating symfony/symfony (v2.8.11 => v2.8.32): Loading from cache
  - Updating sensio/generator-bundle (v3.1.6 => v3.1.7): Loading from cache
  - Updating symfony/phpunit-bridge (v2.8.31 => v2.8.32): Loading from cache

#( 12/13/17@ 6:34PM )( hamza@MacBook-Pro-de-Amrouche ):~/projet/contrib/symfony/symfony-standard@reproduce-the-process✗✗✗
   app/console debug:config        

 // Provide the name of a bundle as the first argument of this command to dump its configuration.                       


Available registered bundles with their extension alias if available:
+----------------------------+------------------------+
| Bundle name                | Extension alias        |
+----------------------------+------------------------+
| AppBundle                  |                        |
| DebugBundle                | debug                  |
| DoctrineBundle             | doctrine               |
| FrameworkBundle            | framework              |
| MonologBundle              | monolog                |
| SecurityBundle             | security               |
| SensioDistributionBundle   | sensio_distribution    |
| SensioFrameworkExtraBundle | sensio_framework_extra |
| SensioGeneratorBundle      |                        |
| SwiftmailerBundle          | swiftmailer            |
| TwigBundle                 | twig                   |
| WebProfilerBundle          | web_profiler           |
+----------------------------+------------------------+

$    app/console debug:config --shell

      _____                  __
     / ____|                / _|
    | (___  _   _ _ __ ___ | |_ ___  _ __  _   _
     \___ \| | | | '_ ` _ \|  _/ _ \| '_ \| | | |
     ____) | |_| | | | | | | || (_) | | | | |_| |
    |_____/ \__, |_| |_| |_|_| \___/|_| |_|\__, |
             __/ |                          __/ |
            |___/                          |___/


Welcome to the Symfony shell (2.8.32 - app/dev/debug).

At the prompt, type help for some help,
or list to get a list of available commands.

To exit the shell, type ^D.

Symfony >

Zwartpet · Dec 13, 2017

Welcome to the Symfony shell (2.8.32 - app/dev/debug).

At the prompt, type help for some help,
or list to get a list of available commands.

To exit the shell, type ^D.

Symfony >

Thats what i mean. You’re not supposed to be stuck in de symfony shell after running a command if i’m not mistaken.

Zwartpet · Dec 13, 2017

Oh wait, thats with —shell. I’ll check when i’m home

Zwartpet · Dec 13, 2017

Apparently it only occurs when running with 'test' in the environment.
For example app/console -e=docker would go fine, but app/console -e=docker_test would result in the shell. Even though the configurations are exactly the same.

Zwartpet · Dec 13, 2017

I am able to reproduce it on a fresh project:

$ symfony new my_project_name 2.8
$ cd my_project_name
$ app/console -e=test

Not able to reproduce in 3.4

Simperfit · Dec 13, 2017

Ok I understand it, I submit a PR to fix the bug

Simperfit · Dec 13, 2017

@Zwartpet see #25487

… alias (Simperfit) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix a bug when passing a letter that could be an alias | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no  | BC breaks? | no | Deprecations? | no  | Tests pass? | yes | Fixed tickets | see #24987 (comment) | License | MIT | Doc PR | Fixing the global in console commands I've introduced a bug where when you pass -e=test it finds it a --shell, this fix the wrong behaviour. cc @Zwartpet Commits ------- a8871de [Console] Fix a bug when passing a letter that could be an alias

symfony#24987.

nicolas-grekas · Jan 21, 2018

breaks in #25825 apparently

…arameterOption.

fabpot · Jan 26, 2018

reverted

…in (Simperfit)" This reverts commit 9107fb0, reversing changes made to abe6e92.

* 2.7: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs [VarDumper] Fix docblock Improve phpdoc to make it more explicit

* 2.8: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Removed assertDateTimeEquals() methods. Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs [VarDumper] Fix docblock Improve phpdoc to make it more explicit

* 3.3: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Removed assertDateTimeEquals() methods. Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions Restore RoleInterface import Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs revert useless tests fixtures changes [VarDumper] Fix docblock Improve phpdoc to make it more explicit

* 3.4: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Removed assertDateTimeEquals() methods. Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions Restore RoleInterface import [Console] Provide a bugfix where an array could be passed Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs revert useless tests fixtures changes [VarDumper] Fix docblock Improve phpdoc to make it more explicit [DI] Fix initialization of legacy containers by delaying include_once

* 4.0: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Removed assertDateTimeEquals() methods. Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions Restore RoleInterface import [Console] Provide a bugfix where an array could be passed Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs revert useless tests fixtures changes [VarDumper] Fix docblock Improve phpdoc to make it more explicit [DI] Fix initialization of legacy containers by delaying include_once

… used with multiple flags (greg-1-anderson) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix hasParameterOption / getParameterOption when used with multiple flags | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no (Fixes BC break in #24987) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25825 | License | MIT | Doc PR | n/a Proposed resolution to #25825: - Back out #24987 - Fix getParameterOption for short options with values, e.g. `-edev` Commits ------- 35f98e2 Follow-on to #25825: Fix edge case in getParameterOption.

carsonbot added Status: Needs Review Console Bug labels Nov 16, 2017

Simperfit force-pushed the bugfix/console-get-the-right-beviour-when-using-short-options branch from 52a6cc2 to 6938a0a Compare November 16, 2017 07:33

xabbuh added this to the 2.7 milestone Nov 16, 2017

xabbuh changed the base branch from 3.3 to 2.7 November 16, 2017 16:59

Simperfit force-pushed the bugfix/console-get-the-right-beviour-when-using-short-options branch from 6938a0a to 363cbaf Compare November 17, 2017 07:44

ro0NL approved these changes Nov 17, 2017

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Nov 17, 2017

chalasr self-requested a review November 17, 2017 12:22

carsonbot added Status: Needs Review and removed Status: Reviewed labels Nov 17, 2017

fabpot reviewed Nov 18, 2017

View reviewed changes

Simperfit force-pushed the bugfix/console-get-the-right-beviour-when-using-short-options branch 2 times, most recently from ffb69d5 to 70f1d96 Compare November 18, 2017 13:49

[Console] Fix global console flag when used in chain

1f8db73

Simperfit force-pushed the bugfix/console-get-the-right-beviour-when-using-short-options branch from 70f1d96 to 1f8db73 Compare November 18, 2017 13:50

chalasr approved these changes Nov 23, 2017

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Nov 23, 2017

ogizanagi approved these changes Nov 24, 2017

View reviewed changes

chalasr merged commit 1f8db73 into symfony:2.7 Nov 26, 2017

This was referenced Nov 30, 2017

Release v3.4.0 #25223

Merged

Release v4.0.0 #25224

Merged

Release v2.7.39 #25317

Merged

This was referenced Dec 4, 2017

Release v2.8.32 #25318

Merged

Release v3.3.14 #25319

Merged

Simperfit mentioned this pull request Dec 13, 2017

[Console] Fix a bug when passing a letter that could be an alias #25487

Merged

This was referenced Jan 18, 2018

[Console] ArgvInput::hasParameterOption confused by short options with values #25825

Closed

WIP #25825: Add a failing test to demonstrate bug introduced in #24987. #25852

Closed

greg-1-anderson added a commit to greg-1-anderson/symfony that referenced this pull request Jan 20, 2018

WIP symfony#25825: Add a failing test to demonstrate bug introduced in #

01ed485

symfony#24987.

greg-1-anderson added a commit to greg-1-anderson/symfony that referenced this pull request Jan 22, 2018

Fixes symfony#25825: Back out symfony#24987 and fix edge case in getP…

542cf6d

…arameterOption.

greg-1-anderson mentioned this pull request Jan 22, 2018

[Console] Fix hasParameterOption / getParameterOption when used with multiple flags #25893

Merged

jakzal mentioned this pull request Jan 26, 2018

[Console] Running commands with short options is broken if value contains "h" #25938

Closed

fabpot added a commit that referenced this pull request Jan 26, 2018

Revert "bug #24987 [Console] Fix global console flag when used in cha…

4f47bb7

…in (Simperfit)" This reverts commit 9107fb0, reversing changes made to abe6e92.

xabbuh mentioned this pull request May 3, 2019

Global console flags don't work when providing multiple options #23876

Closed

Search code, repositories, users, issues, pull requests...

Uh oh!

[Console] Fix global console flag when used in chain #24987

[Console] Fix global console flag when used in chain #24987

Uh oh!

Conversation

Simperfit commented Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chalasr commented Nov 16, 2017

Uh oh!

Simperfit commented Nov 16, 2017 via email

Uh oh!

ro0NL Nov 17, 2017

Choose a reason for hiding this comment

Uh oh!

fabpot Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

ro0NL Nov 17, 2017

Choose a reason for hiding this comment

Uh oh!

fabpot Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

chalasr commented Nov 26, 2017

Uh oh!

Zwartpet commented Dec 13, 2017

Uh oh!

Simperfit commented Dec 13, 2017 via email

Uh oh!

Zwartpet commented Dec 13, 2017

Uh oh!

Simperfit commented Dec 13, 2017

Uh oh!

Zwartpet commented Dec 13, 2017

Uh oh!

Zwartpet commented Dec 13, 2017

Uh oh!

Zwartpet commented Dec 13, 2017

Uh oh!

Zwartpet commented Dec 13, 2017

Uh oh!

Simperfit commented Dec 13, 2017

Uh oh!

Simperfit commented Dec 13, 2017

Uh oh!

nicolas-grekas commented Jan 21, 2018

Uh oh!

fabpot commented Jan 26, 2018

Uh oh!

Uh oh!

Simperfit commented Nov 16, 2017 •

edited

Loading