Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[YAML] Allow to parse custom tags when linting yaml files #24870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

pierredup
Copy link
Contributor

@pierredup pierredup commented Nov 8, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

When using custom tags in yaml, currently the lint:yaml command fails since the flag Yaml::PARSE_CUSTOM_TAGS is not passed through

@xabbuh
Copy link
Member

xabbuh commented Nov 9, 2017

Since the tag parsing feature is opt-in it may be worth it to make at an opt-in feature of the lint command too.

@pierredup
Copy link
Contributor Author

pierredup commented Nov 9, 2017

I did initially add a new option to the command to enable the flag, but wasn't sure if that would count as a new feature then instead of a bug fix?

@chalasr
Copy link
Member

chalasr commented Nov 9, 2017

Seems like a feature yes, although it should have been added at time the constant has been introduced.

@pierredup
Copy link
Contributor Author

pierredup commented Nov 9, 2017

Linting the yaml files is part of our build process, so all our builds keeps failing because of this. So if this can only go in as a new feature in 4.1, then we won't be able to lint yaml files until May next year and after upgrading to Symfony 4 (or we must duplicate the logic in our application) unless this can be enabled by default without the additional option, but that might cause some false-positives if someone hasn't enabled custom tags

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Nov 10, 2017
@fabpot
Copy link
Member

fabpot commented Nov 10, 2017

Thank you @pierredup.

fabpot added a commit that referenced this pull request Nov 10, 2017
…(pierredup)

This PR was squashed before being merged into the 3.3 branch (closes #24870).

Discussion
----------

[YAML] Allow to parse custom tags when linting yaml files

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

When using custom tags in yaml, currently the `lint:yaml` command fails since the flag `Yaml::PARSE_CUSTOM_TAGS` is not passed through

Commits
-------

d8dd91d [YAML] Allow to parse custom tags when linting yaml files
@fabpot fabpot closed this Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.