[DI] Fix "almost-circular" dependencies handling #24822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2017
56bf688 to
71209de
Compare
|
(fabbot failure is false positive) |
71209de to
40c6f35
Compare
|
That means |
|
@ogizanagi how that? I don't think that's the case. |
|
Just trying to dump BarCircular {
+foobar: null
}but that's actually the only way to solve the circular dependency AFAIU. Or did I miss something? |
40c6f35 to
20aa347
Compare
|
@ogizanagi I'm sorry but I'm not able to reproduce your dump. I added type hints on the classes to ensure that |
20aa347 to
63d3caf
Compare
63d3caf to
beb4df7
Compare
ogizanagi
approved these changes
Nov 5, 2017
fabpot
approved these changes
Nov 5, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 5, 2017
…grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix "almost-circular" dependencies handling | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19362, #24775 | License | MIT | Doc PR | - In a situation like the following one, we used to trigger a circular reference exception. But this was a false positive, as the reference is resolvable without hitting the circle. Fixing this exception could be considered as a new feature (because no existing config needs it, since it fails). But for 3.4, this should be considered a bug fix, as reported in #24775: not handling this situation now means creating broken service trees. ``` php $containerBuilder = new ContainerBuilder(); $container->register('foo', FooCircular::class)->setPublic(true) ->addArgument(new Reference('bar')); $container->register('bar', BarCircular::class) ->addMethodCall('addFoobar', array(new Reference('foobar'))); $container->register('foobar', FoobarCircular::class) ->addArgument(new Reference('foo')); $foo = $containerBuilder->get('foo'); ``` Commits ------- beb4df7 [DI] Fix "almost-circular" dependencies handling
This was referenced Nov 5, 2017
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2017
…grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Analyze setter-circular deps more precisely | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24950 | License | MIT | Doc PR | - This PR reverts the effect of #24828 and #24822 on fixtures, except for the new behavior these PRs introduced, which was mostly fine, but missed a few cases. This PR now uses the reference graph to precisely decide which services need circular dependency care, and does not touch the other ones. Commits ------- 9cc4a21 [DI] Analyze setter-circular deps more precisely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a situation like the following one, we used to trigger a circular reference exception. But this was a false positive, as the reference is resolvable without hitting the circle. Fixing this exception could be considered as a new feature (because no existing config needs it, since it fails). But for 3.4, this should be considered a bug fix, as reported in #24775: not handling this situation now means creating broken service trees.