Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpKernel] Let the storage manage the session starts #24774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sroze wants to merge 2 commits into from
Closed

[HttpKernel] Let the storage manage the session starts #24774

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9fa707
Let the storage manage the session starts (fixes #24730)
sroze Oct 31, 2017
597cf34
Remove the "do not start session" test
sroze Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Let the storage manage the session starts (fixes #24730)
  • Loading branch information
@sroze
sroze committed Oct 31, 2017
commit f9fa707346a3e2de59ef59a0232332c867cc863d
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public function collect(Request $request, Response $response, \Exception $except
unset($this->controllers[$request]);
}

if (null !== $session && $session->isStarted()) {
if (null !== $session) {
if ($request->attributes->has('_redirected')) {
$this->data['redirect'] = $session->remove('sf_redirect');
}
Expand Down Expand Up @@ -315,7 +315,7 @@ public function onKernelController(FilterControllerEvent $event)

public function onKernelResponse(FilterResponseEvent $event)
{
if (!$event->isMasterRequest() || !$event->getRequest()->hasSession() || !$event->getRequest()->getSession()->isStarted()) {
if (!$event->isMasterRequest() || !$event->getRequest()->hasSession()) {
Copy link
Copy Markdown
Member

@kbond kbond Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, this change is causing my problem.

return;
}

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.