Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Catching deprecations in isolated tests always adds to the Legacy group #24568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix isolated deprecation groups
  • Loading branch information
alexpott committed Oct 15, 2017
commit b0d4cf0f6619ed351eb6040dbc8abda9ea3e482a
6 changes: 5 additions & 1 deletion 6 src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ public static function register($mode = 0)

$i = count($trace);
while (1 < $i && (!isset($trace[--$i]['class']) || ('ReflectionMethod' === $trace[$i]['class'] || 0 === strpos($trace[$i]['class'], 'PHPUnit_') || 0 === strpos($trace[$i]['class'], 'PHPUnit\\')))) {
// No-op
// If the test is run isolation we don't have the actual test class therefore break on the test case
// class because that will have test object.
if (isset($trace[$i]['class']) && ($trace[$i]['class'] === 'PHPUnit_Framework_TestCase' || $trace[$i]['class'] === 'PHPUnit\Framework\TestCase')) {
break;
}
}

if (isset($trace[$i]['object']) || isset($trace[$i]['class'])) {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.