symfony · Strate · Oct 11, 2017 · Oct 11, 2017 · Oct 12, 2017 · Oct 12, 2017
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
@@ -1917,7 +1917,13 @@ private function export($value)

    private function doExport($value)
    {
-        $export = var_export($value, true);
+        if (is_string($value) && false !== strpos($value, "\n")) {
+            $cleanParts = explode("\n", $value);
+            $cleanParts = array_map(function ($part) { return var_export($part, true); }, $cleanParts);
+            $export = implode('."\n".', $cleanParts);
+        } else {
+            $export = var_export($value, true);
+        }

        if ("'" === $export[0] && $export !== $resolvedExport = $this->container->resolveEnvPlaceholders($export, "'.\$this->getEnv('string:%s').'")) {
            $export = $resolvedExport;

diff --git a/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php b/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php
@@ -187,6 +187,15 @@ public function testServicesWithAnonymousFactories()
        $this->assertStringEqualsFile(self::$fixturesPath.'/php/services19.php', $dumper->dump(), '->dump() dumps services with anonymous factories');
    }

+    public function testDumpAsFilesWhenServicePropertiesContainSpaces()
+    {
+        $container = include self::$fixturesPath.'/containers/container_nl_in_argument.php';
+        $container->compile();
+        $dumper = new PhpDumper($container);
+        $dump = print_r($dumper->dump(array('as_files' => true, 'file' => __DIR__)), true);
+        $this->assertStringMatchesFormatFile(self::$fixturesPath.'/php/container_nl_in_argument_as_files.txt', $dump);
+    }
+
    public function testAddServiceIdWithUnsupportedCharacters()
    {
        $class = 'Symfony_DI_PhpDumper_Test_Unsupported_Characters';

diff --git a/...fony/Component/DependencyInjection/Tests/Fixtures/containers/container_nl_in_argument.php b/...fony/Component/DependencyInjection/Tests/Fixtures/containers/container_nl_in_argument.php
@@ -0,0 +1,19 @@
+<?php
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+$container = new ContainerBuilder();
+
+$container
+    ->register('foo', 'Foo')
+    ->addArgument("string with\nnew line")
+    ->setPublic(true)
+;
+
+$container
+    ->register('foo2', 'Foo')
+    ->addArgument("string with\nnl")
+    ->setPublic(true)
+;
+
+return $container;
diff --git a/...ny/Component/DependencyInjection/Tests/Fixtures/php/container_nl_in_argument_as_files.txt b/...ny/Component/DependencyInjection/Tests/Fixtures/php/container_nl_in_argument_as_files.txt
@@ -0,0 +1,106 @@
+Array
+(
+    [ContainerAx0roru/removed-ids.php] => <?php
+
+return array(
+    'Psr\\Container\\ContainerInterface' => true,
+    'Symfony\\Component\\DependencyInjection\\ContainerInterface' => true,
+);
+
+    [ContainerAx0roru/getFooService.php] => <?php
+
+use Symfony\Component\DependencyInjection\Argument\RewindableGenerator;
+
+// This file has been auto-generated by the Symfony Dependency Injection Component for internal use.
+// Returns the public 'foo' shared service.
+
+return $this->services['foo'] = new \Foo('string with'."\n".'new line');
+
+    [ContainerAx0roru/getFoo2Service.php] => <?php
+
+use Symfony\Component\DependencyInjection\Argument\RewindableGenerator;
+
+// This file has been auto-generated by the Symfony Dependency Injection Component for internal use.
+// Returns the public 'foo2' shared service.
+
+return $this->services['foo2'] = new \Foo('string with'."\n".'nl');
+
+    [ContainerAx0roru/Container.php] => <?php
+
+use Symfony\Component\DependencyInjection\Argument\RewindableGenerator;
+use Symfony\Component\DependencyInjection\ContainerInterface;
+use Symfony\Component\DependencyInjection\Container;
+use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
+use Symfony\Component\DependencyInjection\Exception\LogicException;
+use Symfony\Component\DependencyInjection\Exception\RuntimeException;
+use Symfony\Component\DependencyInjection\ParameterBag\FrozenParameterBag;
+
+/**
+ * This class has been auto-generated
+ * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
+ */
+class ContainerAx0roru extends Container
+{
+    private $parameters;
+    private $targetDirs = array();
+
+    public function __construct()
+    {
+        $dir = $this->targetDirs[0] = dirname(__DIR__);
+        for ($i = 1; $i <= 5; ++$i) {
+            $this->targetDirs[$i] = $dir = dirname($dir);
+        }
+        $this->services = array();
+        $this->fileMap = array(
+            'foo' => __DIR__.'/getFooService.php',
+            'foo2' => __DIR__.'/getFoo2Service.php',
+        );
+
+        $this->aliases = array();
+    }
+
+    public function getRemovedIds()
+    {
+        return require __DIR__.'/removed-ids.php';
+    }
+
+    public function compile()
+    {
+        throw new LogicException('You cannot compile a dumped container that was already compiled.');
+    }
+
+    public function isCompiled()
+    {
+        return true;
+    }
+
+    public function isFrozen()
+    {
+        @trigger_error(sprintf('The %s() method is deprecated since version 3.3 and will be removed in 4.0. Use the isCompiled() method instead.', __METHOD__), E_USER_DEPRECATED);
+
+        return true;
+    }
+
+    protected function load($file, $lazyLoad = true)
+    {
+        return require $file;
+    }
+}
+
+    [ProjectServiceContainer.php] => <?php
+
+// This file has been auto-generated by the Symfony Dependency Injection Component for internal use.
+
+if (!class_exists(ContainerAx0roru::class, false)) {
+    require __DIR__.'/ContainerAx0roru/Container.php';
+}
+
+if (!class_exists(ProjectServiceContainer::class, false)) {
+    class_alias(ContainerAx0roru::class, ProjectServiceContainer::class, false);
+}
+
+return new ContainerAx0roru();
+
+)