Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Form] fix intl related failures #24471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Form] fix intl related failures #24471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Form] fix intl related failures
  • Loading branch information
@xabbuh
xabbuh committed Oct 7, 2017
commit 4e9dc3f5b111613678083dbc25ec260060c137bc
1 change: 1 addition & 0 deletions 1 ...ent/Form/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this, '4.8.1.1');


Copy link
Member

@nicolas-grekas nicolas-grekas Oct 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an extra line here fixes the issue? would it work if the line were a comment instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I just wanted to find out on which branch the AppVeyor build started to fall. Because of the linked PR I thought it should have been this branch. Turns out it wasn't.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, merging #24460 into the 2.7 branch and merge it from there should fully resolve the issue.

\Locale::setDefault('de_AT');

$transformer = new PercentToLocalizedStringTransformer(1, 'integer');
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.