[Console] Escape command usage #24455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What about markdown formatter? should we use htmlspecialchars there? |
Contributor
Author
|
@ro0NL I'm not sure we should change anything on the Markdown usage for now, I don't see any issue with such arguments. |
Contributor
|
AFAIK markdown will render it as HTML tags; If we already quote using backticks we're good :) edit: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Tests/Fixtures/command_2.md looks good already, i think we're fine :) |
ro0NL
approved these changes
Oct 6, 2017
Contributor
ro0NL
left a comment
There was a problem hiding this comment.
I think we should patch 2.7 instead.
5b562d5 to
ef650dd
Compare
Contributor
Author
|
ping @nicolas-grekas |
nicolas-grekas
approved these changes
Oct 8, 2017
Member
|
I also think this should be merged as a bugfix in 2.7. @sroze Can you retarget and rebase? |
ef650dd to
2141056
Compare
Contributor
Author
|
Good point. @chalasr rebased and changed target 👍 |
chalasr
approved these changes
Oct 8, 2017
Member
|
Thank you @sroze. |
chalasr
pushed a commit
that referenced
this pull request
Oct 8, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Console] Escape command usage | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24225 | License | MIT | Doc PR | ø Escape the console usage to prevent arguments named `info` or similar to be formatted. Commits ------- 2141056 Escape command usage when displaying it in the text descriptor
This was referenced Nov 10, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape the console usage to prevent arguments named
infoor similar to be formatted.