[FrameworkBundle] Fix bad interface hint in AbstractController #24431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Oct 5, 2017
|
Does it really make a difference? We have aliases for both interfaces pointing to the same service, don't we? |
|
I think it's sane to have the type that is closer to the injected implementation in the class itself. |
|
Instead of changing the interface, I would instead change the implementation to respect the current interface. |
1c29395 to
1a9bf98
Compare
|
done |
fabpot
approved these changes
Oct 5, 2017
|
But tests are broken. |
xabbuh
approved these changes
Oct 5, 2017
1a9bf98 to
5d29dd0
Compare
Esp. since the FrameworkBundle EngineInterface will be deprecated #21035 |
Tobion
approved these changes
Oct 5, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
…ller (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] Fix bad interface hint in AbstractController | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As spotted by @stof Commits ------- 5d29dd0 [FrameworkBundle] Fix bad interface hint in AbstractController
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted by @stof