[DI] Improve some deprecation messages #24423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Oct 4, 2017
| @@ -282,7 +282,7 @@ public function get($id, $invalidBehavior = self::EXCEPTION_ON_INVALID_REFERENCE | ||
| // calling $this->normalizeId($id) unless necessary. | ||
| for ($i = 2;;) { | ||
| if (isset($this->privates[$id])) { | ||
| @trigger_error(sprintf('Requesting the "%s" private service is deprecated since Symfony 3.2 and won\'t be supported anymore in Symfony 4.0.', $id), E_USER_DEPRECATED); | ||
| @trigger_error(sprintf('The "%s" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or preferably eg implement ServiceSubscriberInterface or use any other dependency injection method instead of using the container at all.', $id), E_USER_DEPRECATED); |
There was a problem hiding this comment.
This is the most critical one, as it will be triggered quite often in 3.4 where services are now private by default.
There was a problem hiding this comment.
Minor reword proposal:
Before:
The "%s" service is private, getting it from the container is deprecated since
Symfony 3.2 and will fail in 4.0. You should either make the service public, or
preferably eg implement ServiceSubscriberInterface or use any other dependency
injection method instead of using the container at all.
After:
The "%s" service is private, getting it from the container is deprecated since
Symfony 3.2 and will fail in 4.0. You should either make the service public or
stop getting services directly from the container (instead, implement
ServiceSubscriberInterface or use other dependency injection methods).
There was a problem hiding this comment.
I would not mention ServiceSubscriberInterface here as this is just one example amongst many other ones.
9f18291 to
2cc8592
Compare
Tobion
reviewed
Oct 4, 2017
| @@ -282,7 +282,7 @@ public function get($id, $invalidBehavior = self::EXCEPTION_ON_INVALID_REFERENCE | ||
| // calling $this->normalizeId($id) unless necessary. | ||
| for ($i = 2;;) { | ||
| if (isset($this->privates[$id])) { | ||
| @trigger_error(sprintf('Requesting the "%s" private service is deprecated since Symfony 3.2 and won\'t be supported anymore in Symfony 4.0.', $id), E_USER_DEPRECATED); | ||
| @trigger_error(sprintf('The "%s" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public or stop getting services directly from the container and use any dependency injection methods instead.', $id), E_USER_DEPRECATED); |
There was a problem hiding this comment.
It's "any method", not "any methods" because only one of the methods should be used, not several at once.
2cc8592 to
3e80760
Compare
fabpot
approved these changes
Oct 5, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [DI] Improve some deprecation messages | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - To improve DX. Commits ------- 3e80760 [DI] Improve some deprecation messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve DX.