[DowCrawler] Default to UTF-8 when possible #24372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can we add a test please? :) |
|
Actually, would it ever NOT match the regexp? |
fabpot
approved these changes
Sep 29, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 29, 2017
…rekas) This PR was merged into the 3.4 branch. Discussion ---------- [DowCrawler] Default to UTF-8 when possible | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17258 | License | MIT | Doc PR | - This can't be ambiguous, let's use UTF-8 when possible. Commits ------- 73eda66 [DowCrawler] Default to UTF-8 when possible
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can't be ambiguous, let's use UTF-8 when possible.