[TwigBundle] Remove profiler related scripting #24281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
javiereguiluz
approved these changes
Sep 26, 2017
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Sep 26, 2017
…iereguiluz) This PR was merged into the 3.3 branch. Discussion ---------- [TwigBundle] Remove profiler related scripting | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> For sanity. Also in case of an exception page we conflict with the profiler scripting/css. ``` Uncaught TypeError: Cannot set property 'className' of null ``` Happens because `Sfjs.createTabs` from the profiler tries to process tabs again, which twig has already done. The code doesnt handle this gracefully. In case of ajax request (edgy yes) we see the CSS conflicting;  Note the table borders. Not sure how and if we want to solve this nor what it might affect otherwise; open for now. Commits ------- eb520e1 Minor reword 02dcdca [TwigBundle] Remove profiler related scripting
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sanity.
Also in case of an exception page we conflict with the profiler scripting/css.
Happens because
Sfjs.createTabsfrom the profiler tries to process tabs again, which twig has already done. The code doesnt handle this gracefully.In case of ajax request (edgy yes) we see the CSS conflicting;
Note the table borders. Not sure how and if we want to solve this nor what it might affect otherwise; open for now.