[DependencyInjection] Don't autoconfigure decorators #24229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
commented
Sep 16, 2017
| @@ -432,6 +433,10 @@ public function getInstanceofConditionals() | ||
| */ | ||
| public function setAutoconfigured($autoconfigured) | ||
| { | ||
| if (null !== $this->decoratedService && $autoconfigured) { |
There was a problem hiding this comment.
Maybe should we also throw in setDecoratedService if $autoconfigured is true?
|
I barely see the logic link between the original issue and making autoconfig/decoration conflict. Can you explain why they should? What is causing the reported exception precisely? |
|
So, debugging this, I'm 👎 on this patch, but would propose another solution: --- a/src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php
+++ b/src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php
@@ -119,6 +119,7 @@ class ResolveInstanceofConditionalsPass implements CompilerPassInterface
$abstract
->setArguments(array())
->setMethodCalls(array())
+ ->setDecoratedService(null)
->setTags(array())
->setAbstract(true);
}I'll let you do the PR if you don't mind? |
|
Closing in favor of #24234. Thanks for debugging this @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 17, 2017
…tionalsPass (dunglas) This PR was merged into the 3.3 branch. Discussion ---------- [DI] Fix decorated service merge in ResolveInstanceofConditionalsPass | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | api-platform/api-platform#414, #24229 | License | MIT | Doc PR | n/a Follows #24229. It's [the patch](#24229 (comment)) proposed by @nicolas-grekas + a test. Commits ------- 2a30908 [DI] Fix decorated service merge in ResolveInstanceofConditionalsPass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoconfiguring decorators create strange problems like this one api-platform/api-platform#414.
As autoconfiguring is on by default when using Symfony SE 3.3, it's better to give an explicit error to the end user.
TODO: