Fix deprecations regarding core commands registered as services #24074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
commented
Sep 3, 2017
| @@ -45,7 +45,7 @@ class CacheClearCommand extends ContainerAwareCommand | ||
| public function __construct($cacheClearer = null, Filesystem $filesystem = null) | ||
| { | ||
| if (!$cacheClearer instanceof CacheClearerInterface) { | ||
| @trigger_error(sprintf('Passing a command name as the first argument of "%s" is deprecated since version 3.4 and will be removed in 4.0. If the command was registered by convention, make it a service instead.', __METHOD__), E_USER_DEPRECATED); |
There was a problem hiding this comment.
The If the command was registered by convention, make it a service instead hint is not useful here as we deprecated convention based registration meanwhile, which gives the very same hint if you use it.
nicolas-grekas
approved these changes
Sep 3, 2017
fabpot
requested changes
Sep 3, 2017
| @@ -45,7 +45,7 @@ class AssetsInstallCommand extends ContainerAwareCommand | ||
| public function __construct($filesystem = null) | ||
| { | ||
| if (!$filesystem instanceof Filesystem) { | ||
| @trigger_error(sprintf('Passing a command name as the first argument of "%s" is deprecated since version 3.4 and will be removed in 4.0. If the command was registered by convention, make it a service instead.', __METHOD__), E_USER_DEPRECATED); | ||
| @trigger_error(sprintf('%s() expects an instance of "%s" as 1st argument since version 3.4. Not passing it is deprecated and will throw a TypeError in 4.0.', __METHOD__, Filesystem::class), E_USER_DEPRECATED); |
33154bf to
4659975
Compare
fabpot
approved these changes
Sep 3, 2017
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Sep 3, 2017
…ervices (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- Fix deprecations regarding core commands registered as services | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23624 (comment) | License | MIT | Doc PR | n/a Current deprecation messages can be confusing (see fixed ticket), this improves them and adds a bunch of missing CHANGELOG/UPGRADE entries on the same topic Commits ------- 4659975 Fix deprecations regarding core commands registered as services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current deprecation messages can be confusing (see fixed ticket), this improves them and adds a bunch of missing CHANGELOG/UPGRADE entries on the same topic